FindBugs
I ran FindBugs on AppFuse last night and found/fixed a number of issues as a result. I'm now down to only a handful left - most of them being "Class is Serializable, but doesn't define serialVersionUID". I tried to generate one using serialver, but I couldn't it to work after numerous attempts. My issues seemed to be classpath related: it wanted the servlet api in my classpath, and once I'd add that, it could find my class. I'll have to try the SerialVer Ant Tasks. Fixing this issue would be nice, but I doubt it's really affecting appfuse-based applications. The other bug is "Inconsistent synchronization" in UserCounterListener.contextInitialized() method. Any tips on solving this one are appreciated.
> UserCounterListener.contextInitialized() method.
> Any tips on solving this one are appreciated.
I guess it's because the methods contextInitialized & contextDestroyed are not synchronized and they use "users" and "counter", while other synchronized methods also use them.
Posted by Guillaume Poirier on August 19, 2004 at 10:15 AM MDT #
Posted by Matt Raible on August 19, 2004 at 10:24 AM MDT #
Posted by dsuspense on August 19, 2004 at 11:12 AM MDT #
Posted by dsuspense on August 19, 2004 at 11:17 AM MDT #
Posted by Matt Raible on August 19, 2004 at 11:57 AM MDT #
Posted by Keller on August 19, 2004 at 12:51 PM MDT #
Posted by Matt Raible on August 19, 2004 at 01:27 PM MDT #
Posted by Gary Blomquist on August 19, 2004 at 02:25 PM MDT #
Posted by Vinu on August 19, 2004 at 02:59 PM MDT #
Posted by Santa Claus on August 20, 2004 at 01:07 AM MDT #
Posted by Santa Claus on August 20, 2004 at 01:07 AM MDT #
Posted by Matt Raible on August 21, 2004 at 10:16 PM MDT #
Posted by Guillaume Poirier on August 22, 2004 at 08:56 AM MDT #
You are correct - I don't really need it - that's why I'm wondering if I should add them. FindBugs says you're supposed to add them to any class that implements Serializable. This is basically any Servlets, Taglibs or model objects. If it won't hurt, I'll add them - but I want to make sure "1L" is the proper value to assign. I'm basically just trying to get a bug-free app (according to FindBugs).
Posted by Matt Raible on August 22, 2004 at 09:44 AM MDT #
Posted by Guillaume Poirier on August 22, 2004 at 10:14 AM MDT #